Experimental watermark #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Watermark feature to the app, enabling users to add watermarks to images with customizable options and EXIF metadata. The implementation includes new activities, data storage for watermark settings, EXIF data extraction, and UI components for image selection and preview. Additionally, several reusable UI components have been enhanced to support the new feature.
New Watermark Feature Implementation:
WatermarkActivity, which handles image selection (including share intents) and displays the watermarking UI. (app/src/main/java/com/sameerasw/essentials/ui/composables/watermark/WatermarkActivity.kt)WatermarkPreviewcomposable for displaying the image preview with watermark and handling different UI states (idle, processing, success, error). (app/src/main/java/com/sameerasw/essentials/ui/composables/watermark/WatermarkPreview.kt)app/src/main/AndroidManifest.xml)FeatureRegistry, making it accessible from the app's feature list. (app/src/main/java/com/sameerasw/essentials/domain/registry/FeatureRegistry.kt)Watermark Data Management and EXIF Extraction:
WatermarkRepositoryto manage user preferences for watermark appearance and content using DataStore, with various update methods for different settings. (app/src/main/java/com/sameerasw/essentials/domain/watermark/WatermarkRepository.kt)MetadataProviderfor extracting EXIF metadata from images, encapsulating camera and shooting information. (app/src/main/java/com/sameerasw/essentials/domain/watermark/MetadataProvider.kt)UI Component Enhancements:
ReusableTopAppBarto allow customization of the container color, supporting better theming for new screens. (app/src/main/java/com/sameerasw/essentials/ui/components/ReusableTopAppBar.kt) [1] [2] [3]SegmentedPickerto optionally support icons for each segment, improving usability for feature-rich pickers. (app/src/main/java/com/sameerasw/essentials/ui/components/pickers/SegmentedPicker.kt) [1] [2]Dependency Updates:
app/build.gradle.kts)